Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove plugins #429

Merged
merged 3 commits into from
Apr 19, 2021
Merged

Remove plugins #429

merged 3 commits into from
Apr 19, 2021

Conversation

obecny
Copy link
Member

@obecny obecny commented Apr 16, 2021

Which problem is this PR solving?

  • removing plugins
  • removing meta packages
  • updating readme
  • updating examples
  • downgrading karma from ver. 5 to 4 - it doesn't work locally

@obecny obecny self-assigned this Apr 16, 2021
@obecny obecny requested a review from a team April 16, 2021 19:21
@obecny obecny mentioned this pull request Apr 16, 2021
Closed
@codecov
Copy link

codecov bot commented Apr 16, 2021 •
edited
Loading

Codecov Report

Merging #429 (37ef64b) into main (0238980) will increase coverage by 0.64%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
+ Coverage   95.18%   95.83%   +0.64%     
==========================================
  Files          12       15       +3     
  Lines         478      624     +146     
  Branches       82       94      +12     
==========================================
+ Hits          455      598     +143     
- Misses         23       26       +3
Impacted Files Coverage Δ
...metry-propagator-ot-trace/src/OTTracePropagator.ts 95.83% <0.00%> (ø)
...s/opentelemetry-propagator-ot-trace/src/version.ts 0.00% <0.00%> (ø)
...propagator-ot-trace/test/OTTracePropagator.test.ts 100.00% <0.00%> (ø)

@vmarchaud vmarchaud requested a review from a team April 16, 2021 19:30
@obecny obecny merged commit 692932e into open-telemetry:main Apr 19, 2021
@obecny obecny deleted the plugins branch April 19, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyladan dyladan dyladan approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@Flarna Flarna Flarna approved these changes

Assignees

@obecny obecny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@obecny @dyladan @vmarchaud @Flarna